[Supervisor][fabric] Fix the error message for non-present fabric card during config reload on SUP #19778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
reviewed
Aug 28, 2024
mlok-nokia
force-pushed
the
stop_swss_syncd_err_msg_
branch
from
d02e318
to
7f8508f
Compare
|
@abdosi I have changed the code to be more generic to check if docker doesn't exist, log a message. Please review it again. |
mlok-nokia
force-pushed
the
stop_swss_syncd_err_msg_
branch
from
25e2206
to
b6e727b
Compare
…d during config reload on SUP Signed-off-by: mlok <marty.lok@nokia.com>
|
@abdosi HI Abhishek, Please help to review this PR. Thanks. |
|
@abdosi reminder to help re-review, thanks. |
abdosi
approved these changes
Nov 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 13, 2024
…d during config reload on SUP (sonic-net#19778) * [Supervisor][fabric] Fix the error message for non-present fabric card during config reload on SUP Added checking to the docker_image_ctrl.j2 stop() method. This change adds code to check if related container exists, then call container stop. Otherwise, just log a message to indicate that "No such container". Fixes sonic-net#19765 --------- Signed-off-by: mlok <marty.lok@nokia.com>
|
Cherry-pick PR to 202405: #20778 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 13, 2024
…d during config reload on SUP (#19778) * [Supervisor][fabric] Fix the error message for non-present fabric card during config reload on SUP Added checking to the docker_image_ctrl.j2 stop() method. This change adds code to check if related container exists, then call container stop. Otherwise, just log a message to indicate that "No such container". Fixes #19765 --------- Signed-off-by: mlok <marty.lok@nokia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…d during config reload on SUP (sonic-net#19778) * [Supervisor][fabric] Fix the error message for non-present fabric card during config reload on SUP Added checking to the docker_image_ctrl.j2 stop() method. This change adds code to check if related container exists, then call container stop. Otherwise, just log a message to indicate that "No such container". Fixes sonic-net#19765 --------- Signed-off-by: mlok <marty.lok@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
After a config reload or a config load_minigraph we see the following error messages in the syslog for non existing fabric cards:
On Sup, for non-existing Fabric slot, its related swss and syncd containers have not been created yet although its related services have been started.
Work item tracking
How I did it
Added checking to the docker_image_ctrl.j2 stop() method. This change adds code to check if related container exists, then call container stop. Otherwise, just log a message to indicate that "No such container". Fixes #19765
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)